feat(backend): added test sessionspaces for development#1275
Open
TBThomas56 wants to merge 1 commit intomainfrom
Open
feat(backend): added test sessionspaces for development#1275TBThomas56 wants to merge 1 commit intomainfrom
TBThomas56 wants to merge 1 commit intomainfrom
Conversation
TBThomas56
requested review from
JamesDoingStuff,
VictoriaBeilsten-Edmands and
davehadley
TBThomas56
force-pushed
the
tbt/test-namespaces
branch
from
6c76d54 to
efd6b5b
Compare
TBThomas56
force-pushed
the
tbt/test-namespaces
branch
from
efd6b5b to
3de3dde
Compare
davehadley
approved these changes
May 5, 2026
| match Sessions::fetch(&ispyb_pool, &mut ldap_connection).await { | ||
| Ok(mut new_sessions) => { | ||
| if let Some(ref statics) = static_sessions { | ||
| statics.merge_into(&mut new_sessions); |
Collaborator
There was a problem hiding this comment.
what prevents these "static" sessions being repeatedly re-applied each loop?
| .as_deref() | ||
| .map(StaticSessions::from_path) | ||
| .transpose() | ||
| .unwrap(); |
Collaborator
There was a problem hiding this comment.
expect is preferred over unwrap
| sessions: | ||
| - proposal_code: ks | ||
| proposal_number: 10000 | ||
| visits: [1, 2, 3, 4, 5] |
| visits: [1, 2, 3, 4, 5] | ||
| instrument: t01 | ||
| members: [] | ||
| gid: null |
Collaborator
There was a problem hiding this comment.
is it OK to have a null gid?
| proposal_number: 10000 | ||
| visits: [1, 2, 3, 4, 5] | ||
| instrument: t01 | ||
| members: [] |
Collaborator
There was a problem hiding this comment.
a session with no members is not very useful?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.